Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contracts commands cache implementation #82

Merged
merged 14 commits into from
May 12, 2024

Conversation

Kemosalamy
Copy link
Collaborator

@Kemosalamy Kemosalamy commented May 9, 2024

worked on remaining commands in the contracts service, added initial caching implementation, integrated sending to the payments service.

next steps after this pull request(since it is getting too large):

  • thorough testing(properly implementing tests)
  • some commands need fixing
  • implement cache in other GET commands
  • properly implement logging

Copy link
Owner

@Ahmad45123 Ahmad45123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3zma 3la 3azma

Copy link
Collaborator

@aboueleyes aboueleyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

images (9).jpeg

@Ahmad45123 Ahmad45123 merged commit fda9c13 into main May 12, 2024
2 checks passed
@Ahmad45123 Ahmad45123 deleted the contracts-commands-cache-implementation branch May 12, 2024 18:16
@HusseinYasser HusseinYasser restored the contracts-commands-cache-implementation branch May 12, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants