feat: Add logging to user profile data #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MahmoudHosamGaber
requested review from
Pandemic1617 and
Akram-Fahim
as code owners
Pandemic1617
approved these changes
May 16, 2024
| Optional<Freelancer> freelancerOptional = freelancerRepository.findById(request.getUserId()); | ||
| if (freelancerOptional.isEmpty()) | ||
| if (freelancerOptional.isEmpty()) { | ||
| logger.info("Freelancer Not Found"); |
There was a problem hiding this comment.
I believe it would be better if this and other similar situations are logged as errors
| @Override | ||
| public AddFreelancerAchievementResponse Run(AddFreelancerAchievementRequest request) { | ||
| logger.info("Add Freelancer Achievement"); |
There was a problem hiding this comment.
Do you think including the requesting user's id would make the logs clearer for this and other function call logs?
ShimaaBetah
force-pushed
the
users-logging
branch
from
16cd872 to
5f7a8fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.