fix(v1.2.1): extension not working on Edge browser due to DOM timing#5
Merged
fix(v1.2.1): extension not working on Edge browser due to DOM timing#5
Conversation
Edge browser injects content scripts slower than Chrome, causing the DOM navigation element check to fail before the page fully loads. Changes: - Increase INJECTION_TIMEOUT from 500ms to 1000ms to give Edge more time - Add URL pattern fallback in isRepositoryPage() for when DOM check fails - This ensures extension works even if GitHub DOM isn't ready yet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Extension fails to activate on Microsoft Edge browser because Edge injects content scripts slower than Chrome. The
isRepositoryPage()function relies on finding a DOM navigation element (
.UnderlineNav-itemor.reponav-item), but on Edge this element may not be present when the script runs.Solution
INJECTION_TIMEOUTfrom 500ms → 1000ms to give Edge more time to loadTesting