Security: Add warning for shell commands in workspace configs#4918
Open
Apoorv13 wants to merge 1 commit intoAider-AI:mainfrom
Open
Security: Add warning for shell commands in workspace configs#4918Apoorv13 wants to merge 1 commit intoAider-AI:mainfrom
Apoorv13 wants to merge 1 commit intoAider-AI:mainfrom
Conversation
Adds a security warning when .aider.conf.yml files from workspace directories contain shell command configurations (lint-cmd, test-cmd, notifications-command). These commands execute automatically via auto-lint which is enabled by default. - Warns users about potential malicious workspace configs - Shows which config file and commands will execute - Home directory configs are trusted (no warning) - Suggests --no-auto-lint --no-auto-test to disable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a security warning when
.aider.conf.ymlfiles from workspace directories contain shell command configurations (lint-cmd,test-cmd,notifications-command).Problem
Malicious repositories can include
.aider.conf.ymlwith arbitrary shell commands that execute automatically when users make code changes (sinceauto-lint: trueis the default). Users receive no warning about this risk.Attack scenario:
.aider.conf.ymlaider main.pylint-cmdexecutes silentlySolution
~/.aider.conf.yml) is trusted--no-auto-lint --no-auto-testto disableExample Warning
Testing