fix: add missing parameters to posthog on_error callback#4930
Open
karesansui-u wants to merge 1 commit intoAider-AI:mainfrom
Open
fix: add missing parameters to posthog on_error callback#4930karesansui-u wants to merge 1 commit intoAider-AI:mainfrom
karesansui-u wants to merge 1 commit intoAider-AI:mainfrom
Conversation
Posthog's consumer calls on_error(error, batch) with two arguments, but posthog_error() only accepts self. This causes a TypeError in the error handler, preventing self.ph = None from executing. As a result, Posthog is never disabled on errors and keeps retrying failed requests. Also removes a debug print statement that was left in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug description
Posthog's consumer thread calls
on_error(error, batch)with two positional arguments, butAnalytics.posthog_error()only acceptsself.When a Posthog error occurs (network failure, server error, etc.):
on_error(error, batch)is called with 2 argsposthog_error(self)receives 3 positional args (self + error + batch)self.ph = Nonenever executes — Posthog is never disabledFix
Accept the two optional parameters that Posthog passes:
Also removes a
print("X" * 100)debug statement that was left in.References
Affected files
aider/analytics.py(L206) — 1 line change