fix: swap foreground/background colors in completion menu current item#4931
Open
karesansui-u wants to merge 1 commit intoAider-AI:mainfrom
Open
fix: swap foreground/background colors in completion menu current item#4931karesansui-u wants to merge 1 commit intoAider-AI:mainfrom
karesansui-u wants to merge 1 commit intoAider-AI:mainfrom
Conversation
The completion-menu.completion.current style has its fg and bg colors reversed compared to the non-current completion-menu style. The bg: prefix is applied to the foreground color and omitted from the background color, causing the selected item's colors to be inverted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug description
The
completion-menu.completion.currentstyle inio.pyhas its foreground and background colors reversed compared to the non-currentcompletion-menustyle.The non-current (correct) pattern:
The current-item (swapped) pattern:
Steps to reproduce
Fix
Apply the
bg:prefix tocompletion_menu_current_bg_colorand remove it fromcompletion_menu_current_color, matching the pattern used for the non-current menu style.Affected files
aider/io.py(L424-427) — 2 line change