Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ignored task definition attributes #30

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rinchsan
Copy link
Contributor

Issue #, if available:

close #29

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

Codecov Report

Merging #30 (8c51a34) into main (cecc5ba) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #30   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          100       100           
  Branches        18        18           
=========================================
  Hits           100       100           
Impacted Files Coverage Δ
src/index.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cecc5ba...8c51a34. Read the comment docs.

@rinchsan
Copy link
Contributor Author

rinchsan commented Jan 27, 2021

Commitlint has failed, what can I do for it?

@CarlosCondor
Copy link

@rinchsan I think the problem with Commitlint is for the branch name because contains "-".

I have the same problem and this PR fixes it.

@rinchsan
Copy link
Contributor Author

rinchsan commented Feb 5, 2021

@CarlosCondor Thank you for your comment!

@stieg Can you review this changes?

@30c4
Copy link

30c4 commented Jun 3, 2021

@stieg @CarlosCondor
Is it possible to merge this PR? I'm running into the same problem and it seems this fixes it.

@gcollazo
Copy link

gcollazo commented Aug 2, 2021

How can I help to get this PR merged?

I just ran the linter locally, and it does not produce any errors. Could you re-run the CI jobs to see if there's an issue?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (cecc5ba) to head (8c51a34).
Report is 124 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #30   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          100       100           
  Branches        18        18           
=========================================
  Hits           100       100           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting 'unexpected key' error
6 participants