Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rest-proxy: split out into standalone module #993

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nosahama
Copy link
Contributor

@nosahama nosahama commented Nov 19, 2024

About this change - What it does

Make rest-proxy component standalone module still running the rapu based webserver, leaving only schema_registry and shared components in src/karapace.

Why this way

We can make future changes that aid in providing the karapace components as separate services.

@nosahama nosahama requested review from a team as code owners November 19, 2024 08:26
eliax1996
eliax1996 previously approved these changes Nov 19, 2024
Copy link
Contributor

@eliax1996 eliax1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the minor note LGTM

bin/smoke-test-rest-proxy.sh Show resolved Hide resolved
@nosahama nosahama force-pushed the nosahama/split-out-rest-proxy branch 9 times, most recently from daccba7 to 7b9bb5c Compare November 19, 2024 20:26
@nosahama nosahama force-pushed the nosahama/split-out-rest-proxy branch from 7b9bb5c to 3cf0f16 Compare November 19, 2024 20:38
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/karapace
  karapace_all.py
  src/karapace/backup
  api.py
  cli.py
  src/karapace/sentry
  sentry_client.py
Project Total  

This report was generated by python-coverage-comment-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants