-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a module for ephemeral participation and a integrated Census+SMS verification #368
Merged
microstudi
merged 16 commits into
AjuntamentdeBarcelona:preprod
from
Platoniq:feature/budgets-2021
May 28, 2021
Merged
Introduce a module for ephemeral participation and a integrated Census+SMS verification #368
microstudi
merged 16 commits into
AjuntamentdeBarcelona:preprod
from
Platoniq:feature/budgets-2021
May 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use custom fork of decidim and feature branch * Change branch to PB05 * Update to latest revision * Update and add locales * Upate to latest revision * Update revision * Update to alt branch * Update to latest revision * Update to latest revision (focus mode compatible with banners) * Reorganize information for budget summary + back link * Merge PB03 * Fix progress bar text for mobile
…cidim (#3) * Introduce a new module to enable ephemeral participation in Decidim - System configuration for verification handlers - Component global flag for ephemeral verification - Budgets tweaks to allow ephemeral verification - User after-registration journey * Update unauthorized_ephemeral_participant_message * Fix decidim/budgets/projects/project_budget_button partial (2) * Ephemeral participation part 3 (#3) * Add some commands * Forbid ephemeral users with verification conflicts to complete registration * Fix bug * Update README * Ephemeral participation part 4 (#4) * Change progress bar color * add a default nickname when creating a ephemeral user * fit i18n copies scopes. fix newly creating organizations without authorizations * fix 2020 budget workflow * Bad commit message Co-authored-by: Vera Rojman <vrojman@protonmail.com>
* Stub census + sms verification * Fix rubocop offenses * Initialize workflow when sms_gateway variables present * Remove 'byebug' * Prevent error with date_of_birth * Add options for districts in verification * Don't require scope in verification * Send sms code after successful census verification * Fix district keys * Update translations * Comment sms code delivery for testing purposes * Add custom ActionAuthorizer for verification scope (district) * Simplify redirection on successful verification * Move form fields into view * Add styles * Improve locales * Improve design * Improve layout * Allow users to reset verification code * Sanitize document number * Add help link for postal code * Add system spec for authorization * some copies. new budget workflow. fix test * config secrets for test Co-authored-by: Ivan Vergés <ivan@platoniq.net>
* Fix typo * Update gemfile * Fix available_authorizations when stored as array * Hide radio button for worfklows not available for ephemeral * Fix class name
leio10
added a commit
that referenced
this pull request
Jun 2, 2021
…s+SMS verification (#368) * ignore capistrano files * add letter opener to production * Update to latest revision and add locales * PB05 (#1) * Use custom fork of decidim and feature branch * Change branch to PB05 * Update to latest revision * Update and add locales * Upate to latest revision * Update revision * Update to alt branch * Update to latest revision * Update to latest revision (focus mode compatible with banners) * Reorganize information for budget summary + back link * Merge PB03 * Fix progress bar text for mobile * Point decidim to main dev branch * Remove locales that should come from decidim repo * Update to AjuntamentdeBarcelona/decidim#6 * Change budgets progress bar color (#5) * Add translations * Chnage progress bar color * Hide follow button for projects * PB01 - Introduce a new module to enable ephemeral participation in Decidim (#3) * Introduce a new module to enable ephemeral participation in Decidim - System configuration for verification handlers - Component global flag for ephemeral verification - Budgets tweaks to allow ephemeral verification - User after-registration journey * Update unauthorized_ephemeral_participant_message * Fix decidim/budgets/projects/project_budget_button partial (2) * Ephemeral participation part 3 (#3) * Add some commands * Forbid ephemeral users with verification conflicts to complete registration * Fix bug * Update README * Ephemeral participation part 4 (#4) * Change progress bar color * add a default nickname when creating a ephemeral user * fit i18n copies scopes. fix newly creating organizations without authorizations * fix 2020 budget workflow * Bad commit message Co-authored-by: Vera Rojman <vrojman@protonmail.com> * Census + SMS verification workflow (#4) * Stub census + sms verification * Fix rubocop offenses * Initialize workflow when sms_gateway variables present * Remove 'byebug' * Prevent error with date_of_birth * Add options for districts in verification * Don't require scope in verification * Send sms code after successful census verification * Fix district keys * Update translations * Comment sms code delivery for testing purposes * Add custom ActionAuthorizer for verification scope (district) * Simplify redirection on successful verification * Move form fields into view * Add styles * Improve locales * Improve design * Improve layout * Allow users to reset verification code * Sanitize document number * Add help link for postal code * Add system spec for authorization * some copies. new budget workflow. fix test * config secrets for test Co-authored-by: Ivan Vergés <ivan@platoniq.net> * Fix PB01 Details (#7) * Fix typo * Update gemfile * Fix available_authorizations when stored as array * Hide radio button for worfklows not available for ephemeral * Fix class name * enable new verificator for ephemeral participation Co-authored-by: Vera Rojman <vrojman@protonmail.com> Co-authored-by: Vera Rojman <vera@platoniq.net>
leio10
added a commit
that referenced
this pull request
Jun 8, 2021
…s+SMS verification (#368) * ignore capistrano files * add letter opener to production * Update to latest revision and add locales * PB05 (#1) * Use custom fork of decidim and feature branch * Change branch to PB05 * Update to latest revision * Update and add locales * Upate to latest revision * Update revision * Update to alt branch * Update to latest revision * Update to latest revision (focus mode compatible with banners) * Reorganize information for budget summary + back link * Merge PB03 * Fix progress bar text for mobile * Point decidim to main dev branch * Remove locales that should come from decidim repo * Update to AjuntamentdeBarcelona/decidim#6 * Change budgets progress bar color (#5) * Add translations * Chnage progress bar color * Hide follow button for projects * PB01 - Introduce a new module to enable ephemeral participation in Decidim (#3) * Introduce a new module to enable ephemeral participation in Decidim - System configuration for verification handlers - Component global flag for ephemeral verification - Budgets tweaks to allow ephemeral verification - User after-registration journey * Update unauthorized_ephemeral_participant_message * Fix decidim/budgets/projects/project_budget_button partial (2) * Ephemeral participation part 3 (#3) * Add some commands * Forbid ephemeral users with verification conflicts to complete registration * Fix bug * Update README * Ephemeral participation part 4 (#4) * Change progress bar color * add a default nickname when creating a ephemeral user * fit i18n copies scopes. fix newly creating organizations without authorizations * fix 2020 budget workflow * Bad commit message Co-authored-by: Vera Rojman <vrojman@protonmail.com> * Census + SMS verification workflow (#4) * Stub census + sms verification * Fix rubocop offenses * Initialize workflow when sms_gateway variables present * Remove 'byebug' * Prevent error with date_of_birth * Add options for districts in verification * Don't require scope in verification * Send sms code after successful census verification * Fix district keys * Update translations * Comment sms code delivery for testing purposes * Add custom ActionAuthorizer for verification scope (district) * Simplify redirection on successful verification * Move form fields into view * Add styles * Improve locales * Improve design * Improve layout * Allow users to reset verification code * Sanitize document number * Add help link for postal code * Add system spec for authorization * some copies. new budget workflow. fix test * config secrets for test Co-authored-by: Ivan Vergés <ivan@platoniq.net> * Fix PB01 Details (#7) * Fix typo * Update gemfile * Fix available_authorizations when stored as array * Hide radio button for worfklows not available for ephemeral * Fix class name * enable new verificator for ephemeral participation Co-authored-by: Vera Rojman <vrojman@protonmail.com> Co-authored-by: Vera Rojman <vera@platoniq.net>
19 tasks
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR implements all the features described in https://github.com/AjuntamentdeBarcelona/decidim-barcelona/projects/2
There is still work to do (mainly add specs) and it also needs real user testing.
📌 Related Issues
📋 Subtasks
📷 Screenshots (optional)