Skip to content

fix(config): convert rate_limit to computed property and clean settin…#133

Open
Ankitpardeshiii wants to merge 1 commit intoAkash-nath29:mainfrom
Ankitpardeshiii:main
Open

fix(config): convert rate_limit to computed property and clean settin…#133
Ankitpardeshiii wants to merge 1 commit intoAkash-nath29:mainfrom
Ankitpardeshiii:main

Conversation

@Ankitpardeshiii
Copy link

Pull Request

Description

Fixes incorrect rate_limit evaluation in the settings module by converting it from a static class attribute to a computed property. This ensures the rate limit value correctly reflects environment variable changes at runtime.

Fixes #131

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test improvements

Changes Made

  • Converted rate_limit to a computed @property
  • Fixed incorrect class-level evaluation of dependent fields
  • Improved readability and formatting of the settings module

Motivation and Context

The rate_limit value was being evaluated at import time, causing it to remain static even when environment variables were changed. This led to incorrect rate limit reporting and confusion during debugging. This change ensures accurate, runtime-derived configuration values.

Testing

Test Configuration

  • OS: Windows 11
  • Node.js Version: 18.17.0
  • Python Version: 3.11.x

@vercel
Copy link

vercel bot commented Feb 5, 2026

@Ankitpardeshiii is attempting to deploy a commit to the akash-nath29's projects Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Incorrect rate_limit string due to static class attribute

1 participant