fix(config): convert rate_limit to computed property and clean settin…#133
Open
Ankitpardeshiii wants to merge 1 commit intoAkash-nath29:mainfrom
Open
fix(config): convert rate_limit to computed property and clean settin…#133Ankitpardeshiii wants to merge 1 commit intoAkash-nath29:mainfrom
Ankitpardeshiii wants to merge 1 commit intoAkash-nath29:mainfrom
Conversation
|
@Ankitpardeshiii is attempting to deploy a commit to the akash-nath29's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Fixes incorrect
rate_limitevaluation in the settings module by converting it from a static class attribute to a computed property. This ensures the rate limit value correctly reflects environment variable changes at runtime.Fixes #131
Type of Change
Changes Made
rate_limitto a computed@propertyMotivation and Context
The
rate_limitvalue was being evaluated at import time, causing it to remain static even when environment variables were changed. This led to incorrect rate limit reporting and confusion during debugging. This change ensures accurate, runtime-derived configuration values.Testing
Test Configuration