Add unit tests for BeastType enum and conversions (u8, felt252)#131
Closed
KevinMomanyi wants to merge 1 commit intoAkatsukiLabs:mainfrom
Closed
Add unit tests for BeastType enum and conversions (u8, felt252)#131KevinMomanyi wants to merge 1 commit intoAkatsukiLabs:mainfrom
KevinMomanyi wants to merge 1 commit intoAkatsukiLabs:mainfrom
Conversation
coxmars
requested changes
Jun 6, 2025
Contributor
There was a problem hiding this comment.
@KevinMomanyi add unit tests in the same file of the beast_type.cairo please
b289af6 to
fbc59cc
Compare
coxmars
requested changes
Jun 12, 2025
Contributor
coxmars
left a comment
There was a problem hiding this comment.
Hi @KevinMomanyi please remove the scarb files from this PR, we only need the unit tests in the beast.cairo
Author
|
well noted @coxmars , thanks. |
fbc59cc to
3338d5d
Compare
coxmars
previously approved these changes
Jun 15, 2025
Contributor
There was a problem hiding this comment.
@KevinMomanyi solve the issues in the workflow, the unit tests are not passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
📝 Summary
#Tasks
test_beast_type_to_u8(), test_u8_to_beast_type_valid(), test_u8_to_beast_type_invalid() and test_beast_type_to_felt252() using str_to_felt252()
test_bidirectional_mapping()
test_u8_to_beast_type_invalid()
Related Issues
Type of Change
Mark with an
xall the checkboxes that apply (like[x]).🔄 Changes Made
What's Changed
Provide a clear and concise description of what you changed and why.
Implementation Details
Describe how you implemented the changes.
Technical Notes
Include any technical details that reviewers should be aware of.
🔧 Tests Results
Describe the tests you performed to verify your changes.
Test Coverage
Evidence
Provide relevant evidence of testing (screenshots, test outputs, etc.).
Testing Notes
Include any special testing considerations or edge cases checked.
🔜 Next Steps
Indicate actions or improvements to be taken after this PR, if applicable.