Skip to content

[FEAT]: Implement Battle trait#135

Merged
coxmars merged 1 commit intoAkatsukiLabs:mainfrom
danielcdz:main
Jun 15, 2025
Merged

[FEAT]: Implement Battle trait#135
coxmars merged 1 commit intoAkatsukiLabs:mainfrom
danielcdz:main

Conversation

@danielcdz
Copy link
Contributor

Pull Request Overview

📝 Summary

  • This PR introduces the Battle trait with the corresponding methods to handle a battle between 2 players.

Related Issues

Type of Change

  • 📝 Documentation (updates to README, docs, or comments)
  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 👌 Enhancement (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)

🔧 Tests Results

image

Test Coverage

  • Unit Tests
  • Integration Tests
  • Manual Testing

Copy link
Contributor

@coxmars coxmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coxmars coxmars merged commit d3969a3 into AkatsukiLabs:main Jun 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

📝 [FEAT]: Implement player vs player Battle model

2 participants

Comments