Skip to content

Comments

feat: create unit tests for beast skill#160

Merged
coxmars merged 1 commit intoAkatsukiLabs:mainfrom
fishonamos:fa-beast
Jul 1, 2025
Merged

feat: create unit tests for beast skill#160
coxmars merged 1 commit intoAkatsukiLabs:mainfrom
fishonamos:fa-beast

Conversation

@fishonamos
Copy link
Contributor

Pull Request Overview

📝 Summary

I added tests for the BeastSkill struct. The tests cover:

  • Initialization of BeastSkill with valid skill spans
  • Skill assignment for Light, Magic, and Shadow beast types
  • Edge cases, such as empty skill spans
  • Validation that only valid skill IDs are accepted
    This will ensure the BeastSkill struct behaves as expected.

Related Issues

Type of Change

Mark with an x all the checkboxes that apply (like [x]).

  • 📝 Documentation (updates to README, docs, or comments)
  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 👌 Enhancement (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)

🔄 Changes Made

What's Changed

Provide a clear and concise description of what you changed and why.

Implementation Details

Describe how you implemented the changes.

Technical Notes

Include any technical details that reviewers should be aware of.

🔧 Tests Results

Describe the tests you performed to verify your changes.

Test Coverage

  • Unit Tests
  • Integration Tests
  • Manual Testing

Evidence

image

Testing Notes

Include any special testing considerations or edge cases checked.

🔜 Next Steps

Indicate actions or improvements to be taken after this PR, if applicable.

@fishonamos
Copy link
Contributor Author

Kindly review @coxmars

@fishonamos fishonamos changed the title feat: create beast tests closes #140 feat: create unit tests for beast skill Jul 1, 2025
@jimenezz22 jimenezz22 requested a review from coxmars July 1, 2025 17:31
@coxmars coxmars merged commit e6f7298 into AkatsukiLabs:main Jul 1, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

📝 [FEAT]: Add Unit Tests for BeastSkill Model

2 participants