Merged
Conversation
Contributor
Author
|
This is a WIP, do not merge yet. |
Contributor
Author
|
@coxmars I'm waiting for you input... please check the comment I left on the issue |
Jonatan-Chaverri
force-pushed
the
add_player_system
branch
from
e2d4da7 to
f34a45a
Compare
Contributor
Author
|
@coxmars applied feedback, PR ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
📝 Summary
Implement player system.
Related Issues
Type of Change
Mark with an
xall the checkboxes that apply (like[x]).🔄 Changes Made
What's Changed
Implement player system. Work in Progress.
Implementation Details
Following Dojo ECS best practices.
Technical Notes
Include any technical details that reviewers should be aware of.
🔧 Tests Results
Tested by unittesting only.
Test Coverage
Evidence
Provide relevant evidence of testing (screenshots, test outputs, etc.).
Testing Notes
Include any special testing considerations or edge cases checked.
🔜 Next Steps
Indicate actions or improvements to be taken after this PR, if applicable.