add onAfterEvent set of listeners #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are called after all systems'
onEventlisteners are called. Which is convenient for systems that depend on other systems.This, however, has a major flaw. Let's say system A needs system B to be done processing an event before it can process it. The current implementation will only work if the event emitter isn't system B, because when system B is the emitter, it's onEvent is not called. System B handles the event after firing it, and thus after all the
onEventandonAfterEventmethods are called. See the visual system's addNode/addEdge for an example of this behavior.