Performance issue due to adding popper classes to body on page with large number of DOM nodes #1019
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When a page contains a large number of DOM nodes, toggling floating elements becomes very slow. This happens because
floating-vue
is adding/removing classes directly onbody
, which triggers reflowing that affects a lot of nodesThis is extremely impactful, especially in analytics application that renders tables with many cells
I do not see that these added classes are used anywhere so I guess they are either legacy or for customization ability
Using the Egdge performance tool, we could see that
![image](https://private-user-images.githubusercontent.com/50204553/299909614-99827050-7663-44a2-bfc0-ee6718d2c2e3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg3NzAzNzAsIm5iZiI6MTczODc3MDA3MCwicGF0aCI6Ii81MDIwNDU1My8yOTk5MDk2MTQtOTk4MjcwNTAtNzY2My00NGEyLWJmYzAtZWU2NzE4ZDJjMmUzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA1VDE1NDExMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTczNmZhOTc3YjNhOWQ3ODgxODgwNmJjZmUxZTI4NTdkYjBlMDZhNGFhMzM3ZDAzOGI3M2Q3ODRiMzVlNmRiYjEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.WwzyLfWyU1hUiHC8UkPfxq9q-NwY41lspm5FkWM42zQ)
![image](https://private-user-images.githubusercontent.com/50204553/299909642-773d4cdc-dba9-43cc-ac6a-f47150642a74.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg3NzAzNzAsIm5iZiI6MTczODc3MDA3MCwicGF0aCI6Ii81MDIwNDU1My8yOTk5MDk2NDItNzczZDRjZGMtZGJhOS00M2NjLWFjNmEtZjQ3MTUwNjQyYTc0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA1VDE1NDExMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTdmNDIyMDhmMWQ2OTQxZWM3Y2Y5NTVhZDhiOWFiMmU3YTZjZTBkNGU5ZDE3NjkwOTE0NGE0NzA4MzViMmEwMGYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.SR5Rx5qZ7MAIGpPbZxe0UKcaD1UVoJhWoqs699eaP8Y)
$_applyShow
and$_applyHide
are affecting many elements during the style recalculation phaseSolution
addPopperClassesToBody
option to disable the adding-popper-classes-to-body behavior