Skip to content

Added more visualisations to Exchange Traded Funds project #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 19, 2024

Conversation

FreeSpirit11
Copy link
Contributor

The new code includes additional visualizations such as a cumulative explained variance plot for PCA components and an elbow plot for determining the optimal number of clusters for KMeans clustering.

Resolves #122

Copy link
Owner

@Akshat111111 Akshat111111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have removed a lot of existing code that might be helpful for the beginners, so add your code in such a manner so it will not affect the existing code.

@FreeSpirit11
Copy link
Contributor Author

FreeSpirit11 commented May 19, 2024

@Akshat111111 , I have made the suggested changes .Please consider reviewing it and tell me if any more changes required.

Copy link
Owner

@Akshat111111 Akshat111111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, now its fine.

@Akshat111111 Akshat111111 merged commit c464213 into Akshat111111:main May 19, 2024
1 check passed
@FreeSpirit11
Copy link
Contributor Author

Hi @Akshat111111 , Please assign labels GSSOC and level 2 to this PR else it wont update in Leader board as mentioned in latest GSSOC guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more visualisations to Exchange Traded Funds project.
2 participants