Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added LSTM and ARIMA #181

Merged
merged 1 commit into from
May 23, 2024
Merged

Added LSTM and ARIMA #181

merged 1 commit into from
May 23, 2024

Conversation

sanskritiagr
Copy link
Contributor

@sanskritiagr sanskritiagr commented May 22, 2024

Related Issue

Prediction was not good enough and also code had some errors. Its working fine now.

Description

I have added lstm and arima. I have also made some changes in prophet code because it had some errors. However, it is working fine now.

Type of PR

  • Bug fix
  • Feature enhancement- Yes
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

[Include any additional information or context that might be helpful for reviewers.]

I have added lstm and arima. I have also made some changes in prophet code because it had some errors. However, it is working fine now.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Our repository.🎊 Thank you so much for taking the time to point this out.

@sanskritiagr
Copy link
Contributor Author

Please add it on GsSoc'24. It is regards with the issue I raised which was assigned to me. Please close that as well after accpeting.

@Akshat111111 Akshat111111 merged commit ffe6ba3 into Akshat111111:main May 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants