Fixed definitions if QT_NO_SYSTEMTRAYICON is defined in gui_helper#910
Open
aselafernando wants to merge 1 commit intoAlbrechtL:nextfrom
Open
Fixed definitions if QT_NO_SYSTEMTRAYICON is defined in gui_helper#910aselafernando wants to merge 1 commit intoAlbrechtL:nextfrom
aselafernando wants to merge 1 commit intoAlbrechtL:nextfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do and why is it necessary?
When compiling with
QT_NO_SYSTEMTRAYICONdefined,QSystemTrayIconis no longer included.Function prototypes that reference
QSystemTrayIconshould not be defined.This PR ensures in gui_helper.h and gui_helper.cpp any references to
QSystemTrayIconare wrapped in a#ifndef QT_NO_SYSTEMTRAYICONdirectiveHow was it tested? How can it be tested by the reviewer?
Compile as normal with
QT_NO_SYSTEMTRAYICONdefinedAny background context you want to provide?
What are the relevant tickets if any?
Screenshots (if appropriate)
Further notes