Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.1-stable] Use alchemy_display_name for page actor names #3029

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

alchemycms-bot
Copy link
Collaborator

Backport

This will backport the following commits from main to 7.1-stable:

Questions ?

Please refer to the Backport tool documentation

If you have a user class that does not implement
name (eg. `Spree::User` or a generic `User` class)
it would return `nil` for Page actor methods (creator,
updater, locker).

We already use `alchemy_display_name` for the current
logged in user displayed in the admin frame.

Using this for the Page actor methods to be consistant
and allow custom user classes to present a user by it.

(cherry picked from commit 00dd34e)
@tvdeyen tvdeyen merged commit 9f8d5b0 into 7.1-stable Sep 6, 2024
55 checks passed
@tvdeyen tvdeyen deleted the backport/7.1-stable/pr-3027 branch September 6, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants