Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tinymce skin files to Sprockets manifest #3062

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Oct 3, 2024

What is this pull request for?

We only tell sprockets to copy the compiled alchemy styles
during precompilation, but we also need the Tinymce skin
files.

Closes #3059

Notable changes (remove if none)

Also removes unused tinymce skin files, as we use the minified versions of these files.

We use the minified versions of these files.
We only tell sprockets to copy the compiled alchemy styles
during precompilation, but we also need the Tinymce skin
files.

Closes AlchemyCMS#3059
@tvdeyen tvdeyen requested a review from a team as a code owner October 3, 2024 13:01
@tvdeyen tvdeyen added the backport-to-7.3-stable Needs to be backported to 7.3-stable label Oct 3, 2024
@tvdeyen tvdeyen enabled auto-merge October 3, 2024 13:04
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.63%. Comparing base (34f8b34) to head (157552f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3062   +/-   ##
=======================================
  Coverage   96.63%   96.63%           
=======================================
  Files         235      235           
  Lines        6323     6323           
=======================================
  Hits         6110     6110           
  Misses        213      213           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit 6ed2cad into AlchemyCMS:main Oct 3, 2024
40 checks passed
@tvdeyen tvdeyen deleted the fix-tinymce-skin-precompilation branch October 3, 2024 13:11
@tvdeyen
Copy link
Member Author

tvdeyen commented Oct 3, 2024

💚 All backports created successfully

Status Branch Result
7.3-stable

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-7.3-stable Needs to be backported to 7.3-stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tiny MCE Alchemy Skin css doesn't not get compiled in production
2 participants