-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rest: add /{network}/epochProgram/:epoch_number #3370
base: staging
Are you sure you want to change the base?
Conversation
@@ -70,6 +70,10 @@ rev = "d170a9f" | |||
default-features = false | |||
optional = true | |||
|
|||
[dependencies.snarkvm-ledger-puzzle-epoch] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we expose this via snarkvm::prelude
or some other reference to avoid having to reimport a snarkVM crate here. Especially one that will require updating the rev
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall I create another PR for snarkVM to reimport the crate?
@@ -209,6 +210,20 @@ impl<N: Network, C: ConsensusStorage<N>, R: Routing<N>> Rest<N, C, R> { | |||
} | |||
} | |||
|
|||
// GET /<network>/epoch_program/{epochNumber} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does the user know what epoch number is the latest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Users can use /latest/height
or /latest/block
to get the latest block height and calculate the epoch_number
What is the intention of this PR? Please provide a description. |
There is a scenario where EpochProgram needs to be distributed from the Server to the Provers, we actually have a fork, and it seems reasonable to provide as much information as possible in the snarkOS RPC, so I propose to merge it. |
No description provided.