run unit tests locally without pharia api keys#16
Open
mooncitydev wants to merge 1 commit intoAleph-Alpha:masterfrom
Open
run unit tests locally without pharia api keys#16mooncitydev wants to merge 1 commit intoAleph-Alpha:masterfrom
mooncitydev wants to merge 1 commit intoAleph-Alpha:masterfrom
Conversation
Made-with: Cursor
mooncitydev
force-pushed
the
fix-conftest-integration-skip-only
branch
from
809329e to
d60ce2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
pytest_collection_modifyitemsintests/conftest.pyskipped every collected test whenPHARIA_DATA_API_BASE_URLandPHARIA_API_KEYwere unset. Local runs never exercised modules like the filter tests unless credentials were configured.This change only applies the skip to integration entrypoints (
test_integration.py,test_create_stage.py), so unit tests run without Pharia API keys.Also adds
tests/test_client_unit.pycovering Client validation and ValueError messages.