New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#218 rewrite tests for database #232

Merged

Dwergaap merged 4 commits into dev from feature/#218-rewrite-tests-for-database

Oct 11, 2023

Collaborator

Dwergaap commented Oct 11, 2023

Describe your changes

Issue ticket number and preferably a link

This change belongs to the following squad(s)

Database
HTTP
OCPP

I have created unit tests for my code

Yes
No
No, I need help with this

Checklist before creating my pull request

My code is properly commented where needed
I have updated the documentation with my changes/additions
I have reviewed my code before creating this pull request
I have made sure that I am targeting the correct branch

Dwergaap added 4 commits

October 9, 2023 13:25


          charger validation test rewriten + more tests

6f02cbe


          small fixes

9dd49a6


          tests passing

86cfdfc


          dev into #218

e94dbc2

Dwergaap requested review from AaronWheezer and Axel-RD

October 11, 2023 11:45

Collaborator

AaronWheezer commented Oct 11, 2023

looks good to me

AaronWheezer approved these changes

View reviewed changes

Axel-RD approved these changes

View reviewed changes

Collaborator

Axel-RD left a comment

Looks fine.

Dwergaap merged commit d29221d into dev

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet