fix(http): use parsed body instead of attributes

AlexandreGerault · Jul 13, 2021 · 7bc7715 · 7bc7715
1 parent 180bc8e
commit 7bc7715
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/src/AGerault/HTTP/Middlewares/HttpMethodMiddleware.php b/src/AGerault/HTTP/Middlewares/HttpMethodMiddleware.php
@@ -11,10 +11,8 @@ class HttpMethodMiddleware implements MiddlewareInterface
 {
     public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
     {
-        $method = $request->getAttribute('_method') ?? $request->getMethod();
-
-        if ($request->getAttribute('_method')) {
-            $request = $request->withMethod($method);
+        if (array_key_exists('_method', $request->getParsedBody())) {
+            $request = $request->withMethod($request->getParsedBody()['_method']);
         }
 
         return $handler->handle($request);

diff --git a/tests/Unit/HTTP/HttpMethodMiddlewareTest.php b/tests/Unit/HTTP/HttpMethodMiddlewareTest.php
@@ -6,7 +6,7 @@
 
 it('should change the request method', function () {
     $request = new ServerRequest("POST", "/");
-    $request = $request->withAttribute("_method", "PUT");
+    $request = $request->withParsedBody(["_method" => "PUT"]);
     $middleware = new HttpMethodMiddleware();
     $handler = new DummyHandler();