Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyprland/workspaces: Add enable-bar-scroll option #3088

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

VAWVAW
Copy link
Contributor

@VAWVAW VAWVAW commented Mar 29, 2024

This PR adds the option to capture scroll events for hyprland workspaces on the whole bar like it works with sway.

When using this, I had a bug that if I enable bar scroll on both hyprland and sway and put sway/workspaces after hyprland/workspaces in modules-left the bar scroll would no longer work on sway. When putting sway/workspaces first, it works on hyprland and sway. I don't know enough to track this down though.

@zjeffer
Copy link
Contributor

zjeffer commented May 2, 2024

When using this, I had a bug that if I enable bar scroll on both hyprland and sway and put sway/workspaces after hyprland/workspaces in modules-left the bar scroll would no longer work on sway. When putting sway/workspaces first, it works on hyprland and sway. I don't know enough to track this down though.

But why would you use both at the same time? 😄

@metakunt
Copy link

Hey guys, can we please have this merged, I tested it and I need the functionality. I want to run the upstream version and not my locally built version, so that I get all updates.

@VAWVAW VAWVAW requested a review from zjeffer May 12, 2024 14:41
@metakunt
Copy link

metakunt commented May 12, 2024

MUCHAS GRACIAS @zjeffer and @VAWVAW
I hope I can use this feature soon

@zjeffer
Copy link
Contributor

zjeffer commented Jun 1, 2024

I'd like to test this out but there are way too many conflicts since the workspaces.cpp file was split up into two files. Can you fix the conflicts?

@JohnMH
Copy link

JohnMH commented Jul 2, 2024

I wish I'd found this before writing #3401. There's a small problem with this, in that events will get handled twice.

For example, scrolling on volume modules will both change the volume and workspace. This is probably not ideal.

@Craeckie
Copy link

Craeckie commented Aug 1, 2024

I rebased the changes (once more) and adapted them to the new way of loading options:
https://github.com/Craeckie/Waybar/tree/hyprland-bar-scroll

@Alexays Alexays force-pushed the master branch 2 times, most recently from d623a89 to a4d31ab Compare September 13, 2024 07:40
@JohnRTitor
Copy link
Contributor

@Alexays could you look at this please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants