-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore consensus cell types in brain and CNS tumors #1036
Explore consensus cell types in brain and CNS tumors #1036
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall plotting strategy looks good, but I have some comments/questions about various categorizations.
Based on this let's make the following groups: | ||
|
||
- Low-grade glioma: Any samples labeled with "Low-grade glioma" or are part of `SCPCP000002` which are categorized as LGG tumors. | ||
- High-grade glioma: Any samples labeled with "High-grade glioma" or are part of `SCPCP000001` which are categorized as HGG tumors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should include Diffuse midline glioma as well (another source).
"macrophage", | ||
"monocyte", | ||
"mononuclear phagocyte", | ||
"dendritic cell" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you only get a myeloid dendritic cell out of the consensus labels? https://pmc.ncbi.nlm.nih.gov/articles/PMC5032838/
stringr::str_subset("T") | ||
|
||
# macro/mono lineage | ||
macro_mono_cells <- c( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could probably call this myeloid and include granulocytes with little to no impact on the results?
analyses/cell-type-consensus/exploratory-notebooks/utils/plotting-functions.R
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, with @jaclyn-taroni's comments addressed. One little additional comment.
```{r} | ||
# t cell subtypes | ||
t_cells <- unique_celltypes |> | ||
stringr::str_subset("T") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems potentially brittle. It looks like maybe you can use "T cell"
?
Co-authored-by: Jaclyn Taroni <19534205+jaclyn-taroni@users.noreply.github.com>
Thanks @jaclyn-taroni and @jashapiro. Based on your comments, I added "Diffuse midline glioma" to the HGG group and then I adjusted the macro/mono group, which I'm now labeling as myeloid. In doing that I ended up removing "dendritic cell", since one of the possible dendritic cells is of lymphoid lineage (see Here's the updated report. |
I meant granulocytes in the general sense without any consideration for whether or not a cell could get annotated as an eosinophil, for example. Put another way, I wasn't paying attention to the potential consensus cell labels. If only neutrophil is possible, that works for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to approve, since I don't think I need to see this again, but the text in the section about myeloid vs. T lineage should get rewritten before this is merged.
analyses/cell-type-consensus/exploratory-notebooks/04-brain-and-cns-consensus-celltypes.Rmd
Outdated
Show resolved
Hide resolved
It looks like there may be some differences between T cell and macrophage infiltrate based on the tumor type. | ||
Here we will look specifically at all T cells and anything in the macrophage/monocyte lineage. | ||
I'm including any cell types that are in our list of possible cell types and a child of [mononuclear phagocyte](https://www.ebi.ac.uk/ols4/ontologies/cl/classes/http%253A%252F%252Fpurl.obolibrary.org%252Fobo%252FCL_0000113?lang=en) in the macro/mono group. | ||
We should also note that "macrophage" here probably refers to microglia instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This text could use a rewrite now.
analyses/cell-type-consensus/exploratory-notebooks/04-brain-and-cns-consensus-celltypes.Rmd
Outdated
Show resolved
Hide resolved
- As expected based on the previous plot, glioblastoma appears to have greater T cell infiltrate than macrophages across all samples. | ||
- There appears to be a handful of samples in the "High-grade glioma" group that also have high T cell infiltrate. | ||
Notably, glioblastoma is a type of HGG. | ||
- Generally, the T cell population seems lowest in LGG. | ||
Ganglioglioma also has fewer samples with high percentage of T cell infiltrate and this is also a LGG. | ||
- It looks like about 50% of the pilocytic astrocytomas have more T cell infiltrate than macrophages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment about lightly rewriting this section.
Co-authored-by: Jaclyn Taroni <19534205+jaclyn-taroni@users.noreply.github.com>
Just noting that I updated the text in b73b573. |
Purpose/implementation Section
Please link to the GitHub issue that this pull request addresses.
Closes #1005
What is the goal of this pull request?
Here I'm summarizing the findings for consensus cell types in all samples that have a brain/cns diagnosis. This includes samples from
SCPCP000001
,SCPCP000002
,SCPCP000009
,SCPCP000010
, andSCPCP000021
. I did not include the samples that belong to multiplexed libraries.Briefly describe the general approach you took to achieve this goal.
Note that in working on this I moved the functions I used for plotting in the osteo notebook to their own script to source in.
If known, do you anticipate filing additional pull requests to complete this analysis module?
Yes.
Results
What types of results does your code produce (e.g., table, figure)?
Here's a copy of the rendered report:
04-brain-and-cns-consensus-celltypes.nb.html.zip
What is your summary of the results?
As mentioned above I think the most interesting thing is the qualitative difference between T cell and macrophage infiltrate. It looks like Glioblastoma have a higher percentage of T cells and much less macrophages while the other types tend to mostly have a higher percentage of macrophages. This trend appears to be more generally divide HGG and LGG too, but again this is qualitative.
Author checklists
Check all those that apply.
Note that you may find it easier to check off these items after the pull request is actually filed.
Analysis module and review
README.md
has been updated to reflect code changes in this pull request.Reproducibility checklist
Dockerfile
.environment.yml
file.renv.lock
file.