Error handling and figure cleanup #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjspielman
approved these changes
Oct 21, 2025
Member
sjspielman
left a comment
sjspielman
left a comment
There was a problem hiding this comment.
LGTM! Noting I get all this as expected when I try with email@example.com
https://github.com/AlexsLemonade/scpca-portal/blob/fb8cbee57b674544932d0371a8d4e24baf75815c/api/scpca_portal/models/api_token.py#L21-L26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two unrelated things in this PR, but they are both small:
I updated the handling of figures in the vignette to make things simpler and remove the need to copy figures around; things should "just work" a bit more nicely now, with the caveat that new vignettes will need to be sure to use the same kind of knitr options.
I added nicer error handling for 400 errors from the get_auth() function. Now it returns part of the response that was received if that response was related to the email address.