Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACS-9155 CI e2e flaky test fix #4336

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

ACS-9155 CI e2e flaky test fix #4336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6ac99ea
ACS-9155 CI e2e run with one worker
akashrathod28 Jan 15, 2025
c145f39
ACS-9155 CI e2e global timeout increase
akashrathod28 Jan 15, 2025
10b2a72
ACS-9155 CI e2e global timeout increase
akashrathod28 Jan 15, 2025
da32d2a
Merge branch 'develop' into ACS-9155-ACA-flaky-test-remove
akashrathod28 Jan 15, 2025
2c497cd
small code fix
akashrathod28 Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions e2e/playwright/info-drawer/src/tests/comments.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/*!

Check failure on line 1 in e2e/playwright/info-drawer/src/tests/comments.e2e.ts

View workflow job for this annotation

GitHub Actions / E2E Playwright - info-drawer

[Info Drawer] › src/tests/comments.e2e.ts:58:7 › Info Drawer - Comments › [C299173] from Personal Files - Comments tab default fields 

  1) [Info Drawer] › src/tests/comments.e2e.ts:58:7 › Info Drawer - Comments › [C299173] from Personal Files - Comments tab default fields 
    Test timeout of 85000ms exceeded.
* Copyright © 2005-2024 Hyland Software, Inc. and its affiliates. All rights reserved.
*
* Alfresco Example Content Application
Expand Down Expand Up @@ -64,7 +64,7 @@
await expect(personalFiles.dataTable.getRowByName(personalFolderName)).toBeVisible();
await personalFiles.dataTable.getRowByName(personalFolderName).click();
await personalFiles.acaHeader.viewDetails.click();
await personalFiles.infoDrawer.commentsTab.click();

Check failure on line 67 in e2e/playwright/info-drawer/src/tests/comments.e2e.ts

View workflow job for this annotation

GitHub Actions / E2E Playwright - info-drawer

[Info Drawer] › src/tests/comments.e2e.ts:58:7 › Info Drawer - Comments › [C299173] from Personal Files - Comments tab default fields 

  1) [Info Drawer] › src/tests/comments.e2e.ts:58:7 › Info Drawer - Comments › [C299173] from Personal Files - Comments tab default fields 
    Error: locator.click: Test timeout of 85000ms exceeded.
    Call log:
      - waiting for getByRole('tab', { name: 'Comments' })


      65 |     await personalFiles.dataTable.getRowByName(personalFolderName).click();
      66 |     await personalFiles.acaHeader.viewDetails.click();
    > 67 |     await personalFiles.infoDrawer.commentsTab.click();
         |                                                ^
      68 |     await expect(personalFiles.infoDrawer.commentInputField).toBeVisible();
      69 |     expect(await personalFiles.infoDrawer.checkCommentsHeaderCount()).toEqual(0);
      70 |     await expect(personalFiles.infoDrawer.addCommentButton).toBeDisabled();
        at /home/runner/work/alfresco-content-app/alfresco-content-app/e2e/playwright/info-drawer/src/tests/comments.e2e.ts:67:48
await expect(personalFiles.infoDrawer.commentInputField).toBeVisible();
expect(await personalFiles.infoDrawer.checkCommentsHeaderCount()).toEqual(0);
await expect(personalFiles.infoDrawer.addCommentButton).toBeDisabled();
Expand All @@ -84,7 +84,7 @@
await favoritePage.infoDrawer.addCommentToNode(commentText);
await expect(favoritePage.infoDrawer.addCommentButton).toBeDisabled();
expect(await favoritePage.infoDrawer.checkCommentsHeaderCount()).toEqual(1);
expect(await favoritePage.infoDrawer.verifyCommentsCountFromList(1));
await favoritePage.infoDrawer.verifyCommentsCountFromList(1);
});

test('[C299189] from Shared Files - Comments are displayed ordered by created date in descending order', async ({ sharedPage }) => {
Expand Down Expand Up @@ -121,7 +121,7 @@
await recentFilesPage.infoDrawer.addCommentToNode(commentText);
await expect(recentFilesPage.infoDrawer.addCommentButton).toBeDisabled();
expect(await recentFilesPage.infoDrawer.checkCommentsHeaderCount()).toEqual(1);
expect(await recentFilesPage.infoDrawer.verifyCommentsCountFromList(1));
await recentFilesPage.infoDrawer.verifyCommentsCountFromList(1);
});

test('[C299196] Comment info display - File from Favorites', async ({ favoritePage }) => {
Expand Down
2 changes: 1 addition & 1 deletion projects/aca-playwright-shared/src/base-config/playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export const getGlobalConfig: PlaywrightTestConfig = {
/* Retry on CI only */
retries: env.CI ? 2 : 0,
/* Opt out of parallel tests on CI. */
workers: 3,
workers: env.CI ? 1 : 3,
/* Reporter to use. See https://playwright.dev/docs/test-reporters */
reporter: [['list'], ...getReporter()],
globalSetup: require.resolve('./global.setup'),
Expand Down
2 changes: 1 addition & 1 deletion projects/aca-playwright-shared/src/utils/timeouts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,5 @@ export const timeouts = {
extendedTest: 150 * 1000,
extendedLongTest: 200 * 1000,
webServer: 240 * 1000,
globalSpec: 60 * 10 * 1000
globalSpec: 60 * 20 * 1000
};
Loading