forked from algorand/indexer
-
Notifications
You must be signed in to change notification settings - Fork 0
Optimize timestamp filters for transactions #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance tests on PostgresOld queries
New queries
Conclusion
|
Performance tests on CockroachDBI could only test the new queries in a light indexer. Unfortunately, the amount of data in a light indexer database is not large enough to be certain that the execution plans are efficient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull requests optimizes the filters
after-time
andbefore-time
in theGET /v2/transactions
endpoint.The rationale behind this optimization is to convert timestamps into rounds (since transactions have lookup indexes based in their round number). This hopefully will avoid an inefficient query execution plan.
Test Plan
Tested in a local environment with a CRDB light indexer. The resulting execution plan seems to be more efficient, but the amount of data in a light indexer is too small to see a performance improvement.
This change would need to be tested in a full indexer (i.e. full history) to verify that CRDB is picking the right query execution plan.