Closed
Conversation
Added Auto Connect Function and settings option set to auto connect after 10 seconds of being connected as a controller S1+ by default it is disabled. Also modified the connection failed function and will attempt to reconnect after 2 minutes and will continue until connected Partially connected to issue #7
Merge Because I forgot
Dev Merge fixed my appveyor
Changed Flight Plan Not held message to be shorter
Possible working Auto CPDLC message if Flight Plan Not Held
Merge vSMR Master Changes
19wintersp
suggested changes
May 26, 2025
19wintersp
left a comment
19wintersp
left a comment
There was a problem hiding this comment.
Please check your indentation settings (I suggest having it auto-detect per-file), otherwise looks fine.
Author
|
I have fixed the indentation settings Also apologise with the messed-up commits as I was not originally working on branches for this |
19wintersp
suggested changes
May 26, 2025
19wintersp
left a comment
19wintersp
left a comment
There was a problem hiding this comment.
Indentation is still mixed in SMRPlugin.cpp
The commits really aren't ideal but can be squashed in the merge.
Fix Indentations hopefully fixes it
19wintersp
reviewed
May 26, 2025
Co-authored-by: Patrick Winters <61561933+19wintersp@users.noreply.github.com>
Collaborator
|
Closed as duplicate of VATSIM-UK#6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected polling interval to be random between 45-75 seconds Fixes #9
I have not tested this yet. However, I have refactored my code to make more sense and took suggestions from #12, which splits up the changes to individual Pull Requests.
I include my current build for those who cannot compile and test.
https://ci.appveyor.com/project/MrAdder/vsmr/builds/52123480
For a build with #19, use
https://ci.appveyor.com/project/MrAdder/vsmr/builds/52123426
@19wintersp