Add kafka messages consumer to Framework #2624
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinboulais
force-pushed
the
Add-kafka-messages-consumer-to-the-Framework
branch
2 times, most recently
from
3b68353 to
a3f2190
Compare
martinboulais
force-pushed
the
Add-kafka-messages-consumer-to-the-Framework
branch
from
a3f2190 to
85a78af
Compare
2 tasks
graduta
requested changes
Jan 31, 2025
| async _handleEvent(message) { | ||
| for (const listener of this._listeners) { | ||
| try { | ||
| await listener(message); |
There was a problem hiding this comment.
What do you think in case of having lots of listeners, to use .catch() and remove the await so that listeners will not await in sequence
There was a problem hiding this comment.
Indeed, fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I DON'T have JIRA ticket
Added a class to listen to ECS kafka messages and automatically parse them using protobuf