Fix issue #6262: Add success/failure indicators for file read/edit op…

…erations
All-Hands-AI · Feb 7, 2025 · e3eb7e3 · e3eb7e3
1 parent 37ddc56
commit e3eb7e3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/frontend/src/components/features/chat/messages.tsx b/frontend/src/components/features/chat/messages.tsx
@@ -1,4 +1,5 @@
 import React from "react";
+import type { Message } from "#/message";
 import { ChatMessage } from "#/components/features/chat/chat-message";
 import { ConfirmationButtons } from "#/components/shared/buttons/confirmation-buttons";
 import { ImageCarousel } from "../images/image-carousel";

diff --git a/frontend/src/state/chat-slice.ts b/frontend/src/state/chat-slice.ts
@@ -154,6 +154,11 @@ export const chatSlice = createSlice({
         causeMessage.success = !ipythonObs.content
           .toLowerCase()
           .includes("error:");
+      } else if (observationID === "read" || observationID === "edit") {
+        // For read/edit operations, we consider it successful if there's content and no error
+        causeMessage.success =
+          observation.payload.content.length > 0 &&
+          !observation.payload.content.toLowerCase().includes("error:");
       }
 
       if (observationID === "run" || observationID === "run_ipython") {