Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use user_id as token set indicator for settings #6595

Merged
merged 9 commits into from
Feb 4, 2025
Merged

Conversation

malhotra5
Copy link
Contributor

@malhotra5 malhotra5 commented Feb 3, 2025

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

We use github_token in the request state to indicate user is authed, whereas its preferable to user_id instead


Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:16ce8e7-nikolaik   --name openhands-app-16ce8e7   docker.all-hands.dev/all-hands-ai/openhands:16ce8e7

@malhotra5 malhotra5 marked this pull request as draft February 3, 2025 19:09
@malhotra5 malhotra5 changed the title Refactor: Use user_id indicator instead of gh_token for auth User user_id as token set indicator for settings Feb 3, 2025
@malhotra5 malhotra5 changed the title User user_id as token set indicator for settings Use user_id as token set indicator for settings Feb 3, 2025
@malhotra5 malhotra5 marked this pull request as ready for review February 3, 2025 20:02
malhotra5 and others added 2 commits February 3, 2025 17:44
Co-authored-by: Engel Nyst <enyst@users.noreply.github.com>
Co-authored-by: Engel Nyst <enyst@users.noreply.github.com>
@malhotra5 malhotra5 merged commit 7151f75 into main Feb 4, 2025
16 checks passed
@malhotra5 malhotra5 deleted the refactor/use-user-id branch February 4, 2025 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants