Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify fn calling usage #6596

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Simplify fn calling usage #6596

wants to merge 6 commits into from

Conversation

enyst
Copy link
Collaborator

@enyst enyst commented Feb 3, 2025

Give a summary of what the PR does, explaining any non-trivial design decisions

This PR proposes to clean up mock_function_calling var from the agent. The llm knows if it supports it.


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:cdb9248-nikolaik   --name openhands-app-cdb9248   docker.all-hands.dev/all-hands-ai/openhands:cdb9248

@enyst enyst marked this pull request as draft February 3, 2025 20:16
@enyst enyst marked this pull request as ready for review February 3, 2025 21:38
f'Function calling not enabled for model {self.llm.config.model}. '
'Mocking function calling via prompting.'
)
self.mock_function_calling = True
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't really used in the agent, it's used in llm.py

@enyst enyst changed the title Refactor messages Simplify fn calling usage Feb 3, 2025
@enyst enyst requested a review from xingyaoww February 3, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant