Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #6262: Add success/failure indicators for file read/edit operations #6653

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

neubig
Copy link
Contributor

@neubig neubig commented Feb 7, 2025

This pull request fixes #6262.

The changes made directly address the core issue and implement the requested functionality:

  1. Added success/failure indicators for file read/edit operations in the chat interface
  2. Added tests to verify the behavior
  3. Implemented success detection based on content presence and absence of error messages

The changes are minimal and focused on the core functionality, with no unnecessary modifications to other files.


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:2fd9e3c-nikolaik   --name openhands-app-2fd9e3c   docker.all-hands.dev/all-hands-ai/openhands:2fd9e3c

@enyst enyst requested a review from amanape February 8, 2025 23:01
Copy link
Member

@amanape amanape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: "Success/failure" behavior is not consistent for file reading and editing
3 participants