Conversation
frombunny
approved these changes
Aug 18, 2025
Member
frombunny
left a comment
There was a problem hiding this comment.
일단은... 로직 자체가 매우 거대해서 뭐가 더 나은 로직이다라는 건 판별하기가 어려울 것 같고..!
제가 보기엔 오류가 발생할만한 부분은 딱히 없기도 하고, 충분히 테스트를 해봤다면
이 코드는 일단 병합하고 추후 리팩토링을 고려하거나 해봐야 할 것 같아요!
여기에 스웨거 명세 추가해주시고 병합해주세요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 관련 이슈
✅ 작업 분류
✨ 작업 내용
👥 전달사항
✅ 체크리스트
📸 스크린샷