Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patterning can get stuck on row n-1 and never finish #662

Closed
Adrienne200 opened this issue Apr 21, 2024 · 8 comments · Fixed by #740
Closed

Patterning can get stuck on row n-1 and never finish #662

Adrienne200 opened this issue Apr 21, 2024 · 8 comments · Fixed by #740
Assignees
Milestone

Comments

@Adrienne200
Copy link

AYAB software version: 0.99.0-rc6
Computer/OS: Intel Mac, Big Sur
Knitting machine: KH910
AYAB hardware: Interface

It's new in the rc4-rc6 timeframe, I've never seen this happen before.

Steps:
All settings and prefs at default, so Infinite Repeat is unchecked
You need to actually air-knit, Simulate is different and doesn't show the issue.
Open the Triangles sample. It is 10 rows.
(Optional: set the start row to 7 for more convenient testing.)
Start on the left, remembering to pause for two seconds after crossing the turn mark.
and knit as usual for 8 rows, noticing the end-of-row sounds from the hardware's buzzer and the "ding" from computer's speakers.
Keep going for rows 9 and 10 without slowing down.

Result: Usually it will select row 10 and complete as expected. But sometimes (about half the time on Mac, rarely on Windows but it did happen) I could get it to just keep repeating row 9 without ever finishing.

@X-sam
Copy link
Member

X-sam commented Jul 29, 2024

possibly related to AllYarnsAreBeautiful/ayab-firmware#190 ?

@X-sam X-sam moved this from Todo to Needs Testing in AYAB 1.0.0 Release Tracking Jul 29, 2024
@jonathanperret
Copy link
Contributor

I've done a number of swatches with (recent) 1.0-dev firmware and not hit this, I think. @Adrienne200 are you up for trying it with 1.0.0-beta1?

@Adrienne200
Copy link
Author

Still happening with the Beta 1 build. It has failed on 2 of my first 3 runs of the most basic test, the triangles sample with all settings at default.
I'll be testing with other machines over the next couple of days, to see if it's unique to this one machine.

@jonathanperret
Copy link
Contributor

Thanks for testing again. I’ll give it a try tomorrow on my 910 (from a Mac) with your exact instructions to see if I can reproduce it.

@dl1com dl1com added this to the 1.0.0 milestone Oct 27, 2024
@clholgat clholgat moved this from Needs Testing to Todo in AYAB 1.0.0 Release Tracking Oct 27, 2024
@jonathanperret
Copy link
Contributor

@Adrienne200 I'm trying to looking into this more seriously. I seem to remember on the call last week you sais it occurred only with an AYAB Interface?
One thing I'd like to understand more clearly is what you see happening on the last row. Does the desktop app ever get to the point where it says "Finished knitting"? Or does it just stop reacting to rows being completed on the machine? Or does it keep emitting "dings" but repeating row 9?

@clholgat
Copy link
Contributor

clholgat commented Dec 3, 2024

I can easily repro on my 270 with a Jens interface.

If the last row is row N. I never get the end of row beep for row N-1 and then a few seconds later, the desktop software gives me the end of pattern beeps but nothing more from the interface.

Digging.

@clholgat
Copy link
Contributor

clholgat commented Dec 3, 2024

Found a fix AllYarnsAreBeautiful/ayab-firmware#217

@jonathanperret
Copy link
Contributor

🛎 A proposed fix for this is in #740 and can be tested in the release referenced there.

@github-project-automation github-project-automation bot moved this from Needs Testing to Done in AYAB 1.0.0 Release Tracking Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

5 participants