Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed lick sensor #1035

Merged
merged 9 commits into from
Aug 31, 2024
Merged

fixed lick sensor #1035

merged 9 commits into from
Aug 31, 2024

Conversation

saskiad
Copy link
Collaborator

@saskiad saskiad commented Aug 23, 2024

closes #997

@saskiad saskiad requested review from jtyoung84 and dyf and removed request for jtyoung84 August 30, 2024 20:53
@jtyoung84
Copy link
Collaborator

Converting an optional field to a required field is a breaking change. We may need to increment the schema major version.

@saskiad saskiad added this pull request to the merge queue Aug 31, 2024
Merged via the queue into dev with commit 79dc73b Aug 31, 2024
5 checks passed
@saskiad saskiad deleted the feat_997_fipexample branch August 31, 2024 02:46
@jtyoung84
Copy link
Collaborator

The next time we release dev into main, we'll need to increment the version to 2.0. I probably won't upgrade the services to 2.0 for a few months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyf dyf dyf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix mistakes in fip_behavior_rig
3 participants
@saskiad @jtyoung84 @dyf