Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default type for external_links #1054

Merged
merged 1 commit into from
Sep 9, 2024
Merged

fix: default type for external_links #1054

merged 1 commit into from
Sep 9, 2024

Conversation

helen-m-lin
Copy link
Contributor

closes #1046

@helen-m-lin helen-m-lin marked this pull request as ready for review September 6, 2024 23:02
@saskiad saskiad added this pull request to the merge queue Sep 9, 2024
Merged via the queue into dev with commit 0104e43 Sep 9, 2024
5 checks passed
@saskiad saskiad deleted the fix-1046-external_links_default branch September 9, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbirman dbirman dbirman approved these changes

@jtyoung84 jtyoung84 Awaiting requested review from jtyoung84

@saskiad saskiad Awaiting requested review from saskiad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default value for external_links should match type
3 participants
@helen-m-lin @dbirman @saskiad