Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registry Enum for common BaseName values #420

Merged
merged 34 commits into from
Aug 4, 2023
Merged

Conversation

Sun-flow
Copy link
Contributor

closes #369
closes #419

Adds JAX to Institution, and changes some values in RRID schema to expect PIDName/Institution
Removes Registry Basenames from classes, replaced with Enumerated values for Registry

@Sun-flow Sun-flow added the enhancement New feature or request label Jul 18, 2023
@Sun-flow Sun-flow requested review from dyf and saskiad July 18, 2023 22:58
@Sun-flow Sun-flow self-assigned this Jul 18, 2023
Copy link
Member

@dyf dyf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small thing, then gtg

src/aind_data_schema/subject.py Outdated Show resolved Hide resolved
@Sun-flow Sun-flow requested a review from dyf August 4, 2023 22:32
@dyf dyf merged commit ca882cb into main Aug 4, 2023
7 checks passed
@dyf dyf deleted the feat-369-source-to-institution branch August 4, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Registry Enum source and rrid in subject schema
3 participants