Skip to content

Feat/fix 009#10

Merged
JonghunYu merged 4 commits intodevelopfrom
feat/fix-009
Nov 14, 2025
Merged

Feat/fix 009#10
JonghunYu merged 4 commits intodevelopfrom
feat/fix-009

Conversation

@JonghunYu
Copy link
Member

@JonghunYu JonghunYu commented Nov 14, 2025

Summary by CodeRabbit

  • New Features

    • Automated CI builds now produce pre-built cross-platform executables (macOS ARM/Intel, Linux) for download.
    • A standalone command-line executable entry point was added so the tool can be run as a CLI.
  • Documentation

    • Installation guide updated with steps to download the latest CI-built binaries from the workflow artifacts.

@coderabbitai
Copy link

coderabbitai bot commented Nov 14, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Adds a new GitHub Actions workflow at .github/workflows/build.yml that triggers on pushes to main, sets up Go 1.23, downloads modules, runs tests and a linter, builds three cross-platform binaries (gi-darwin-arm64, gi-darwin-amd64, gi-linux-amd64) and uploads them as an artifact with 7-day retention. Introduces a CLI entrypoint at cmd/gi/main.go that sets a version variable to "dev", calls cmd.SetVersion(version) and cmd.Execute(), exiting on error. Updates DEVELOPMENT.md with instructions to download CI-built binaries. Changes .gitignore to root-scoped /gi. Updates a closed issue timestamp under .issues.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Review .github/workflows/build.yml for correct triggers, runner setup, Go caching, module download, test/lint steps, artifact names and retention.
  • Inspect cmd/gi/main.go for correct version propagation and error handling.
  • Verify .gitignore change to /gi is intentional and won't untrack needed files.
  • Confirm DEVELOPMENT.md instructions match artifact names and repository UI flow.
  • Note: .issues/closed timestamp change is informational only.

Poem

🐇 I hopped through lines to spark CI light,
Three little binaries baked through the night,
A tiny main whispers "version dev" true,
Docs point the way to the carroted brew,
I twitch my nose and celebrate the new delight 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Title check ❓ Inconclusive The title 'Feat/fix 009' is vague and non-descriptive, using only a branch reference without conveying the actual changes made in the pull request. Use a descriptive title that clearly summarizes the main change, such as 'Add CI/CD build workflow and binary distribution' or similar to reflect the actual implementation work.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c53f7de and def259c.

📒 Files selected for processing (1)
  • .github/workflows/build.yml (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
DEVELOPMENT.md (1)

5-5: Update Go version prerequisite to clarify CI environment.

The prerequisites (line 5) state "Go 1.21 or later," but the workflow uses Go 1.23. While this is compatible, it could be clearer for developers setting up local environments. Consider updating the prerequisite to "Go 1.23 or later" to match the CI version, or explicitly document that CI uses a newer version than the minimum required.

Additionally, the artifact download instructions (lines 36–41) could clarify that these steps retrieve artifacts from the main branch specifically. If developers need artifacts from develop or other branches, they should navigate to the Actions tab directly and filter by branch.

Apply this diff to improve clarity:

- Go 1.21 or later
+ Go 1.23 or later (CI environment; local development requires 1.21+)

And update the download instructions:

- # Download latest CI-built binaries (requires repo access):
+ # Download latest CI-built binaries from main (requires repo access):
  # 1. git pull origin main
  # 2. Go to GitHub → Actions → "Build binaries" workflow
- # 3. Download gi-binaries-<sha> artifact for your platform
+ # 3. Find the run matching your commit SHA and download gi-binaries-<sha>

Also applies to: 36-41

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7a9ae6c and d1bfcc7.

📒 Files selected for processing (3)
  • .github/workflows/build.yml (1 hunks)
  • .issues/closed/009-build-in-cicd.md (1 hunks)
  • DEVELOPMENT.md (1 hunks)
🔇 Additional comments (1)
.github/workflows/build.yml (1)

1-44: Binary filenames verified and match successfully.

The workflow artifact upload (lines 41–43) expects:

  • gi-darwin-arm64
  • gi-darwin-amd64
  • gi-linux-amd64

The Makefile build-all target with BINARY_NAME=gi produces exactly these names, confirmed in the Makefile build commands and documented in README.md and RELEASE.md. The workflow will successfully locate and upload all binaries with no silent failures.

@JonghunYu JonghunYu merged commit 4f3a724 into develop Nov 14, 2025
3 of 4 checks passed
@JonghunYu JonghunYu deleted the feat/fix-009 branch November 14, 2025 13:53
JonghunYu added a commit that referenced this pull request Nov 14, 2025
* fix: fixed permission issue when run make install

* feat: added 010

* Close issue #10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant