Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert bools to true/false #3296

Merged
merged 37 commits into from
Jan 7, 2024
Merged

Convert bools to true/false #3296

merged 37 commits into from
Jan 7, 2024

Conversation

EricClaeys
Copy link
Collaborator

No description provided.

@EricClaeys
Update functions.php: Add extra type checking
8c3b33e
@EricClaeys
Update hostapd.php: remove unneeded include_once()
92391d1 
Also, fix icon
@EricClaeys
Update liveview.php: minor wording changes
8ce9ad8
@EricClaeys
Update functions.php: bug: fix missing comma
0df08a9
@EricClaeys
Update options.json.repo: convert 0/1 to false/true
2c0bb26
@EricClaeys
Update options.json.repo: fix wrong option for legacy mode
60f6283
@EricClaeys
Update ASI_functions.cpp: don't use quotes around numbers
1460e51
@EricClaeys
Update functions.php: return false instead of 0
d5a96c4
@EricClaeys
Update createAllskyOptions.php: output true/false
49bbd0e 
Also do better job of knowing what values to quote and do that for all output.
@EricClaeys
Update allskySettings.php: misc minor improvements and changes
6195346 
Changes needed as a result of testing with true/false
@EricClaeys
Update allsky.sh: convert 1 to true
dc44212
@EricClaeys
Update variables.sh: convert 0/1 to false / true
e872c40
@EricClaeys
Update ASI_functions.cpp: convert 0/1 to true/false
d0460ae
@EricClaeys
Update ASI_functions.cpp: fix %d to %s
43e211e
@EricClaeys
Update outputJSONwithEqual.php: Output false/true for booleans
68f04d8
@EricClaeys
Update check_allsky.sh: check for true/false instead of 1/0
2620375 
Also, remove code to download a newer version if there is one on GitHub.  That was originally done when we thought there would be a lot of changes, but the scripts is pretty settled now.
@EricClaeys
Update endOfDay.sh: check for true instead of 1
5a83326
@EricClaeys
Update darkCapture.sh: check for false, not 0
4475671
@EricClaeys
Update check_allsky.sh: remove unused variables
782ff01
@EricClaeys
Update check_allsky.sh: fix Usage line
d28304f
@EricClaeys
Update generateForDay.sh: trivial formatting changes
0902199
@EricClaeys
Update postToMap.sh: check for true instead of 1
8424708 
Make some variables local
@EricClaeys
Update postToMap.sh: fix: add missing &&
3c097a1
@EricClaeys
Update postToMap.sh: same bug fix
1fc60a7
@EricClaeys
Update upload.sh: check for false, not 0
9fd86bc
@EricClaeys
Update removeBadImages.sh: check for true, not 1
b3d3b08 
Also:
* Change indentation
* Use -n
@EricClaeys
Update timelapse.sh: Show error log, don't point to it.
bd574d7
@EricClaeys
Update updateWebsiteConfig.sh: split long line for readability
55e3a86
@EricClaeys
Update copy_notification_image.sh: check for true, not 1
8aa14a3
@EricClaeys
Update darkSubtract.sh: check for true, not 1
a802f8e
@EricClaeys EricClaeys changed the base branch from master to v2024.xx.xx January 7, 2024 03:34
@EricClaeys EricClaeys merged commit c982e84 into v2024.xx.xx Jan 7, 2024
1 check passed
@EricClaeys EricClaeys deleted the Convert-bools-to-true/false branch January 7, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@EricClaeys