4226 bug image resize parameters in web gui are not saved and revert to 0 #4230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makeChanges.sh can then use the value rather than having to look in the settings file for every setting. It's more efficient to have convertJSON.php do it, since it already read the settings file.
They make the invoker's code a little cleaner.
* It already allowed for that, but it's more obvious now with variable names that reflect it. * use o_, w_, e_, and d_ functions.
* See comments for why. * Also, rename script to updateJsonFile.sh
Also rename a variable so it better reflects what it is, and shorten a message.
Handling width and height settings at same time is more efficient and produces only a single error message when needed. Also: * Centralize restoring code in restoreSettings() * Use updateJsonFile.sh to make multiple updates instead of separate update_json_file()'s
Can update CHANGES() in a "read" subshell. Do some shellcheck fixes
0 pixels means the default should be used
EricClaeys
deleted the
4226-bug-image-resize-parameters-in-web-gui-are-not-saved-and-revert-to-0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4266