Open
Conversation
rharter
requested changes
Jan 15, 2019
Collaborator
rharter
left a comment
rharter
left a comment
There was a problem hiding this comment.
Thanks for this change. I think it's a good one, but the focus code should live on the parent TwoFingerGestureDetector instead of just the RotateGestureDetector, since they'll all have a focal point.
Also, I realize this old code isn't well formatted, but I'd rather not add to the poor formatting, so please check whitespace, don't leave empty javadoc comments, and group member variables together.
library/src/main/java/com/almeros/android/multitouch/RotateGestureDetector.java
Outdated
Show resolved
Hide resolved
library/src/main/java/com/almeros/android/multitouch/RotateGestureDetector.java
Outdated
Show resolved
Hide resolved
mariopce
commented
Jan 15, 2019
library/src/main/java/com/almeros/android/multitouch/TwoFingerGestureDetector.java
Show resolved
Hide resolved
mariopce
commented
Jan 15, 2019
rharter
reviewed
Jan 15, 2019
library/src/main/java/com/almeros/android/multitouch/RotateGestureDetector.java
Outdated
Show resolved
Hide resolved
Author
|
Now I think PR could be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add information for rotation where is a focus point
Remove reqTouchScreen to support Samsung Dex
This change is