including ignorereservations when creating order in service (#495)

* including ignorereservations when creating order in service * force ignoreReservations value in constructor * fixed test input
Altinn · Apr 22, 2024 · 0b96880 · 0b96880
1 parent 2ef0376
commit 0b96880
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/src/Altinn.Notifications.Core/Models/Orders/NotificationOrder.cs b/src/Altinn.Notifications.Core/Models/Orders/NotificationOrder.cs
@@ -23,7 +23,7 @@ public class NotificationOrder : IBaseNotificationOrder
     public NotificationChannel NotificationChannel { get; internal set; }
 
     /// <inheritdoc/>>    
-    public bool IgnoreReservation { get; set; }
+    public bool IgnoreReservation { get; internal set; }
 
     /// <inheritdoc/>>
     public Creator Creator { get; internal set; }
@@ -53,7 +53,7 @@ public NotificationOrder(
         Creator creator,
         DateTime created,
         List<Recipient> recipients,
-        bool ignoreReservation = false)
+        bool ignoreReservation)
     {
         Id = id;
         SendersReference = sendersReference;

diff --git a/src/Altinn.Notifications.Core/Services/OrderRequestService.cs b/src/Altinn.Notifications.Core/Services/OrderRequestService.cs
@@ -61,7 +61,8 @@ public async Task<NotificationOrderRequestResponse> RegisterNotificationOrder(No
             orderRequest.NotificationChannel,
             orderRequest.Creator,
             created,
-            orderRequest.Recipients);
+            orderRequest.Recipients, 
+            orderRequest.IgnoreReservation);
 
         NotificationOrder savedOrder = await _repository.Create(order);
 

diff --git a/src/Altinn.Notifications.Integrations/Extensions/ServiceCollectionExtensions.cs b/src/Altinn.Notifications.Integrations/Extensions/ServiceCollectionExtensions.cs
@@ -45,7 +45,7 @@ public static void AddAltinnClients(this IServiceCollection services, IConfigura
     {
         _ = config.GetSection(nameof(PlatformSettings))
             .Get<PlatformSettings>()
-            ?? throw new ArgumentNullException(nameof(config), "Required AltinnServiceSettings is missing from application configuration");
+            ?? throw new ArgumentNullException(nameof(config), "Required PlatformSettings is missing from application configuration");
 
         services
             .Configure<PlatformSettings>(config.GetSection(nameof(PlatformSettings)))

diff --git a/...nn.Notifications.IntegrationTests/Notifications/OrdersController/OrdersControllerTests.cs b/...nn.Notifications.IntegrationTests/Notifications/OrdersController/OrdersControllerTests.cs
@@ -45,7 +45,8 @@ public OrdersControllerTests(IntegrationTestWebApplicationFactory<Controllers.Or
             NotificationChannel.Email,
             new Creator("ttd"),
             DateTime.UtcNow,
-            new List<Recipient>());
+            new List<Recipient>(),
+            false);
 
         _orderWithStatus = new(
             Guid.NewGuid(),