removed self link for oerd/{id}/notifications endpoint (#412)

* removed self link for notifications endpoint

* added missing enum

src/Altinn.Notifications/Extensions/ResourceLinkExtensions.cs

@@ -38,7 +38,6 @@ public static void SetResourceLinks(this NotificationOrderExt order)
         {
             Self = self,
             Status = self + "/status",
-            Notifications = self + "/notifications"
         };
     }
 

src/Altinn.Notifications/Models/NotificationChannelExt.cs

@@ -8,5 +8,10 @@ public enum NotificationChannelExt
     /// <summary>
     /// The selected channel for the notification is email.
     /// </summary>
-    Email
+    Email,
+
+    /// <summary>
+    /// The selected channel for the notification is sms.
+    /// </summary>
+    Sms
 }

src/Altinn.Notifications/Models/OrderResourceLinksExt.cs

@@ -21,10 +21,4 @@ public class OrderResourceLinksExt
     /// </summary>
     [JsonPropertyName("status")]
     public string Status { get; set; } = string.Empty;
-
-    /// <summary>
-    /// Gets or sets the notifications link 
-    /// </summary>
-    [JsonPropertyName("notifications")]
-    public string Notifications { get; set; } = string.Empty;
 }

test/Altinn.Notifications.IntegrationTests/Notifications/OrdersController/GetByIdTests.cs

@@ -73,7 +73,6 @@ public async Task GetById_SingleMatchInDb_ReturnsOk()
             Created = persistedOrder.Created,
             Links = new()
             {
-                Notifications = $"{refLinkBase}/{id}/notifications",
                 Self = $"{refLinkBase}/{id}",
                 Status = $"{refLinkBase}/{id}/status"
             },

test/Altinn.Notifications.Tests/Notifications/TestingMappers/OrderMapperTests.cs

@@ -67,7 +67,6 @@ public void MapToNotificationOrderExt_AreEquivalent()
             Links = new OrderResourceLinksExt()
             {
                 Self = $"https://platform.at22.altinn.cloud/notifications/api/v1/orders/{order.Id}",
-                Notifications = $"https://platform.at22.altinn.cloud/notifications/api/v1/orders/{order.Id}/notifications",
                 Status = $"https://platform.at22.altinn.cloud/notifications/api/v1/orders/{order.Id}/status"
             }
         };