fixed settings name (#407)

* fixed settings name * renamed in all classes * catching all exceptions * simplified log msg
Altinn · Feb 2, 2024 · f11016b · f11016b
1 parent d92abe4
commit f11016b
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 4 deletions.
diff --git a/src/Altinn.Notifications.Core/Configuration/KafkaSettings.cs b/src/Altinn.Notifications.Core/Configuration/KafkaSettings.cs
@@ -18,5 +18,5 @@ public class KafkaSettings
     /// <summary>
     /// THe name of the general sms queue topic
     /// </summary>
-    public string SmsQueTopicName { get; set; } = string.Empty;
+    public string SmsQueueTopicName { get; set; } = string.Empty;
 }
diff --git a/src/Altinn.Notifications.Core/Services/SmsNotificationService.cs b/src/Altinn.Notifications.Core/Services/SmsNotificationService.cs
@@ -36,7 +36,7 @@ public SmsNotificationService(
         _dateTime = dateTime;
         _repository = repository;
         _producer = producer;
-        _smsQueueTopicName = kafkaSettings.Value.SmsQueTopicName;
+        _smsQueueTopicName = kafkaSettings.Value.SmsQueueTopicName;
     }
 
     /// <inheritdoc/>

diff --git a/src/Altinn.Notifications.Integrations/Kafka/Producers/KafkaProducer.cs b/src/Altinn.Notifications.Integrations/Kafka/Producers/KafkaProducer.cs
@@ -61,6 +61,11 @@ public async Task<bool> ProduceAsync(string topic, string message)
             _logger.LogError(ex, "// KafkaProducer // ProduceAsync // Permanent error: {Message} for message (value: '{DeliveryResult}')", ex.Message, ex.DeliveryResult.Value);
             return false;
         }
+        catch (Exception ex)
+        {
+            _logger.LogError(ex, "// KafkaProducer // ProduceAsync // An exception occurred.");
+            return false;
+        }
 
         return true;
     }

diff --git a/...ons.IntegrationTests/Notifications/TriggerController/Trigger_SendSmsNotificationsTests.cs b/...ons.IntegrationTests/Notifications/TriggerController/Trigger_SendSmsNotificationsTests.cs
@@ -80,7 +80,7 @@ private HttpClient GetTestClient()
                 });
                 services.Configure<Core.Configuration.KafkaSettings>(opts =>
                 {
-                    opts.SmsQueTopicName = _topicName;
+                    opts.SmsQueueTopicName = _topicName;
                 });
 
                 // Set up mock authentication and authorization               

diff --git a/...inn.Notifications.Tests/Notifications.Core/TestingServices/SmsNotificationServiceTests.cs b/...inn.Notifications.Tests/Notifications.Core/TestingServices/SmsNotificationServiceTests.cs
@@ -181,6 +181,6 @@ private static SmsNotificationService GetTestService(ISmsNotificationRepository?
             producer = producerMock.Object;
         }
 
-        return new SmsNotificationService(guidService.Object, dateTimeService.Object, repo, producer, Options.Create(new KafkaSettings { SmsQueTopicName = _smsQueueTopicName }));
+        return new SmsNotificationService(guidService.Object, dateTimeService.Object, repo, producer, Options.Create(new KafkaSettings { SmsQueueTopicName = _smsQueueTopicName }));
     }
 }