Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core + persistence logic for sms notification summaries #GPCActive #416

Merged
merged 19 commits into from
Feb 8, 2024

Conversation

acn-sbuad
Copy link
Contributor

@acn-sbuad acn-sbuad commented Feb 6, 2024

Description

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added
  • All tests run green

@acn-sbuad acn-sbuad changed the title Core logic for supporting sms notification summaries Core + persistence logic for sms notification summaries #GPCActive Feb 6, 2024
@acn-sbuad acn-sbuad requested a review from tba76 February 6, 2024 15:25
Copy link
Contributor

@khanrn khanrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Member

@SandGrainOne SandGrainOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one comment. Looking good.

Copy link

sonarqubecloud bot commented Feb 8, 2024

@acn-sbuad acn-sbuad merged commit 51b2fd7 into main Feb 8, 2024
7 checks passed
@acn-sbuad acn-sbuad deleted the feature/414-core-sms-summary branch February 8, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants