Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NationalIdentityNumber and OrganisationNumber added to Recipient models #458

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

acn-sbuad
Copy link
Contributor

@acn-sbuad acn-sbuad commented Mar 5, 2024

Description

Database:

  • RecipientId column removed from notification tables and all procedures/funcs mentioning it

  • OrganisationNumber and NationalIdentityNumber included in notifications tables and functions

  • Service and repository logic updated to reflect model changes.

  • API: orgNo or nationalIdentity number in orderRequest is ignored for now.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Copy link

sonarqubecloud bot commented Mar 5, 2024

Copy link
Contributor

@khanrn khanrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acn-sbuad acn-sbuad merged commit f6d14f4 into main Mar 6, 2024
7 checks passed
@acn-sbuad acn-sbuad deleted the feature/436-db-changes branch March 6, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants